when no repo, use synchronous upload for rpm #1249
Conversation
|
/retest |
|
/retest |
|
/retest |
|
|
||
| # For rpm plugin >= 3.32.5, use synchronous upload endpoint when no repository is provided | ||
| # For older versions, always use the create endpoint (backward compatibility) | ||
| if repository is None and self.pulp_ctx.has_plugin( |
There was a problem hiding this comment.
This is in common-context and be called with any kind-of PulpRepositoryContext. All you're checking here is that the pulp-instance being talked-to has rpm>=3.32.5. What if I'm invoking this from, say, pulp python content upload? You need to check the kind-of RepositoryContext to see that it's for a plugin that supports the new call in addition to making sure that plugin is the right version or higher.
There was a problem hiding this comment.
So from all the plugins, just 2x had issues
pulp-file, which doesn't seem to support the synchronous uploads, so i am overwriting this context in the file context.
And rpm which had an issue, which is resolved in the latest version of the plugin
The rest are passing the tests just fine, their synchronous implementations seems to be older and working as expected with the updated context.
There was a problem hiding this comment.
A note, the one not passing it's test is exactly the rpm one, in nightly, which is the most confusing part.
2 participants
Extending the rpm uploads to use synchronous endpoint